Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callout colors #29

Closed
wants to merge 1 commit into from
Closed

Add callout colors #29

wants to merge 1 commit into from

Conversation

xaqbr
Copy link

@xaqbr xaqbr commented Sep 25, 2022

Previous dark:
![image](https://user-images.githubusercontent.com/3822492/192142322-01c42be8-9b01-452e-a5f1-88bbfc535735.png | width=100)

New dark:
image

Previous light:
image

New light:
image

Fixes #26

@insanum
Copy link
Owner

insanum commented Sep 26, 2022

This looks good. I like the way the callouts pop.

Can you please change all your color arrays to use variables inside theme-dark or theme-light? Then you can cut the amount of CSS in half as you've duplicated most selectors for both dark/light. You'll only need to specify a single selector with the corresponding variable color which will work for both dark/light.

@insanum
Copy link
Owner

insanum commented Oct 15, 2022

If you'd like to see this committed please simplify the code as previously requested and update for the new Obsidian v1.x theming style (i.e. rebase your changes).

@insanum
Copy link
Owner

insanum commented Mar 7, 2024

Different pull request that picked up the ideas for callouts here was merged.

@insanum insanum closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add colors for callouts
2 participants